Horton

Re: Skipping logical replication transactions on subscriber side

Peter Eisentraut <peter.eisentraut@enterprisedb.com>

View thread View on postgr.es
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: Masahiko Sawada <sawada.mshk@gmail.com>, "tanghy.fnst@fujitsu.com" <tanghy.fnst@fujitsu.com>, vignesh C <vignesh21@gmail.com>, Greg Nancarrow <gregn4422@gmail.com>, "houzj.fnst@fujitsu.com" <houzj.fnst@fujitsu.com>, Alexey Lesovsky <lesovsky@gmail.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>, "osumi.takamichi@fujitsu.com" <osumi.takamichi@fujitsu.com>
Date: 2022-01-24T14:06:11Z
Lists: pgsql-hackers 
On 22.01.22 03:54, Amit Kapila wrote:
> Won't we already do that for Alter Subscription command which means
> nothing special needs to be done for this? However, it seems to me
> that the idea we are trying to follow here is that as this option can
> lead to data inconsistency, it is good to allow only superusers to
> specify this option. The owner of the subscription can be changed to
> non-superuser as well in which case I think it won't be a good idea to
> allow this option. OTOH, if we think it is okay to allow such an
> option to users that don't have superuser privilege then I think
> allowing it to the owner of the subscription makes sense to me.

I don't think this functionality allows a nonprivileged user to do 
anything they couldn't otherwise do.  You can create inconsistent data 
in the sense that you can choose not to apply certain replicated data. 
But a subscription owner has to have write access to the target tables 
of the subscription, so they already have the ability to write or not 
write any data they want.

Commits

  1. Test ALIGNOF_DOUBLE==4 compatibility under ALIGNOF_DOUBLE==8.

  2. Reorder subskiplsn in pg_subscription to avoid alignment issues.

  3. Add ALTER SUBSCRIPTION ... SKIP.

  4. Optionally disable subscriptions on error.

  5. Update docs of logical replication for commit 8d74fc96db.

  6. Respect permissions within logical replication.

  7. Fix regression test failure caused by commit 8d74fc96db.

  8. Add a view to show the stats of subscription workers.

  9. Add logical change details to logical replication worker errcontext.

  10. Rename LOGICAL_REP_MSG_STREAM_END to LOGICAL_REP_MSG_STREAM_STOP.

  11. Fix typo in protocol.sgml.

  12. Remove unused argument in apply_handle_commit_internal().

  13. Fix replication of in-progress transactions in tablesync worker.

  14. Reorder pg_sequence columns to avoid alignment issue