Re: move hash_any to utils/hash/hashfn.c
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>,
Pg Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2019-01-25T20:05:37Z
Lists: pgsql-hackers
Andres Freund <andres@anarazel.de> writes: > On 2019-01-25 16:35:18 -0300, Alvaro Herrera wrote: >> Would anybody object too hard if I move hash_any() and friends to >> src/backend/utils/hash/hashfn.c and the declarations to >> src/include/utils/hashutils.h? > I hate the current split quite a bit, albeit for somewhat different > reasons. We make things like tag_hash, uint32_hash unnecessarily more > expensive by adding an entirely useless external function call. And > some of these can be fairly hot (e.g. for syscache). So yea, let's > move this stuff together. +1 regards, tom lane
Commits
-
Move hash_any prototype from access/hash.h to utils/hashutils.h
- af38498d4c9b 12.0 landed