Re: [HACKERS] Incomplete startup packet errors
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2019-03-02T03:25:50Z
Lists: pgsql-hackers
Andrew Dunstan <andrew.dunstan@2ndquadrant.com> writes: > On 3/1/19 6:49 PM, Tom Lane wrote: >> No patch referenced, but I assume you mean only for the >> zero-bytes-received case, right? No objection if so. > Patch proposed by Christoph Berg is here: > https://www.postgresql.org/message-id/20190228151336.GB7550%40msg.df7cb.de Meh. That doesn't silence only the zero-bytes case, and I'm also rather afraid of the fact that it's changing COMMERROR to something else. I wonder whether (if client_min_messages <= DEBUG1) it could result in trying to send the error message to the already-lost connection. It might be that that can't happen, but I think a fair amount of rather subtle (and breakable) analysis may be needed. regards, tom lane
Commits
-
Don't log incomplete startup packet if it's empty
- 342cb650e0ff 12.0 landed