Horton

Re: BUG #16666: Slight memory leak when running pg_ctl reload

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: bchen90@163.com
Cc: pgsql-bugs@lists.postgresql.org
Date: 2020-10-12T17:37:51Z
Lists: pgsql-bugs 
PG Bug reporting form <noreply@postgresql.org> writes:
> I found slighting memory leakage occured when running pg_ctl reload command
> for the following code segment(guc.c:6726-6740). When runing 'pg_ctl
> reload', for these string type PGC_POSTMASTER GUC variables like
> 'unix_socket_directories', the following code segment will leak newval's
> memery.

Yeah, you're right.  If there's a "newextra" chunk, that'll get
leaked too.

Even counting that, it's not very plausible that one would SIGHUP a
server often enough that the bloat would become obvious, since these
values typically aren't very large.  But it's clearly a bug.

Patch applied, thanks for the report!

			regards, tom lane

Commits

  1. Fix memory leak when guc.c decides a setting can't be applied now.