Horton

Re: Catalog domain not-null constraints

Peter Eisentraut <peter@eisentraut.org>

View thread
From: Peter Eisentraut <peter@eisentraut.org>
To: jian he <jian.universality@gmail.com>, Aleksander Alekseev <aleksander@timescale.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>, Alvaro Herrera <alvherre@alvh.no-ip.org>, vignesh C <vignesh21@gmail.com>
Date: 2024-03-20T09:43:47Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Fix ALTER DOMAIN NOT NULL syntax

  2. Catalog domain not-null constraints

  3. Add tests for domain-related information schema views

On 19.03.24 10:57, jian he wrote:
> this new syntax need to be added into the alter_domain.sgml's synopsis and also
> need an explanation varlistentry?

The ALTER DOMAIN reference page refers to CREATE DOMAIN about the 
details of the constraint syntax.  I believe this is still accurate.  We 
could add more detail locally on the ALTER DOMAIN page, but that is not 
this patch's job.  For example, the details of CHECK constraints are 
also not shown on the ALTER DOMAIN page right now.

> +  false, /* connoinherit */
> +  false, /* conwithoutoverlaps */
> +  false); /* is_internal */
> 
> /* conwithoutoverlaps */
> should be
> /* conperiod */

Good catch, thanks.