Re: Patch: Remove gcc dependency in definition of inline functions
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Marko Kreen <markokr@gmail.com>
Cc: Kurt Harriman <harriman@acm.org>, pgsql-hackers@postgresql.org
Date: 2009-12-16T14:50:53Z
Lists: pgsql-hackers
Marko Kreen <markokr@gmail.com> writes: > On 12/16/09, Kurt Harriman <harriman@acm.org> wrote: >> For gcc, I think the __attribute__ has to come after the function's >> parameter list, rather than before the return type. > No. [ squint... ] That's nowhere documented that I can find: all the examples in the gcc docs show __attribute__ after the parameters. It does seem to work, but should we rely on it? The bigger problem though is that not all versions of gcc understand always_inline: $ gcc -Wall check.c check.c:3: warning: `always_inline' attribute directive ignored which I think is sufficient reason to put an end to this sub-thread. We have no particular need for force-inline semantics anyway, as long as the compiler behaves reasonably for unreferenced inlines, which gcc always has. regards, tom lane