Horton

Re: is_superuser versus set_config_option's parallelism check

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org, Robert Haas <robertmhaas@gmail.com>
Date: 2024-08-10T18:38:03Z
Lists: pgsql-hackers 
Nathan Bossart <nathandbossart@gmail.com> writes:
> Regarding returning 0 instead of -1 for the parallel case, I think that
> follows.  While doing some additional research, I noticed this return value
> was just added in December (commit 059de3c [0]).  Before that, it
> apparently assumed that elevel >= ERROR.  With that and your analysis of
> the call sites, it seems highly unlikely that changing it will cause any
> problems.

Hah ... so the failure to think clearly about which value to use
was mine :-(.

> For the errcode, I do see that we pretty consistently use
> ERRCODE_INVALID_TRANSACTION_STATE for "can't do thing during a parallel
> operation."  In fact, it looks like all but one use is for parallel errors.

OK, I'll leave that alone but will change the return code.

			regards, tom lane

Commits

  1. Allow adjusting session_authorization and role in parallel workers.

  2. Fix failure to verify PGC_[SU_]BACKEND GUCs in pg_file_settings view.