Re: No error checking when reading from file using zstd in pg_dump

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: Tomas Vondra <tomas@vondra.me>, Evgeniy Gorbanev <gorbanyoves@basealt.ru>, pgsql-hackers@lists.postgresql.org
Date: 2025-07-01T15:42:28Z
Lists: pgsql-hackers
Daniel Gustafsson <daniel@yesql.se> writes:
> In preparing for concluding this I've attached a v8 which is the patchset in v7
> squashed into a single commit with an attempt at a commit message.

Glancing through this, I observe a couple of minor typos:

+     * Returns number of bytes read (this might be less than 'size' if EOF was
+     * reached).  Exits via pg_fatal all for error conditions.

s/all for/for all/

+        pg_fatal("coud not write to file: %m");

s/coud/could/

There are some minor typos in the proposed commit message, too.

			regards, tom lane



Commits

  1. pg_dump: Fix compression API errorhandling