Horton

Re: pgsql: Remove WITH OIDS support, change oid catalog column visibility.

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2019-01-03T18:40:42Z
Lists: pgsql-hackers 
I noticed that this patch has broken restores of existing dump files:

psql:testbed.public.backup:82: ERROR:  unrecognized configuration parameter "default_with_oids"

Quite aside from the fact that this won't work if the user tries to
restore in single-transaction or no-error mode, this is really really
unhelpful because it's impossible to tell whether the error is
ignorable or not, except by digging through the dump file.

What you should do is restore that GUC, but add a check-hook that throws
an error for an attempt to set it to "true".

			regards, tom lane

Commits

  1. Remove line duplicated during conflict resolution.

  2. Re-add default_with_oids GUC to avoid breaking old dump files.

  3. Remove WITH OIDS support, change oid catalog column visibility.