Re: improving user.c error messages

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>

To: Nathan Bossart <nathandbossart@gmail.com>

Cc: Robert Haas <robertmhaas@gmail.com>, Alvaro Herrera <alvherre@alvh.no-ip.org>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>

Date: 2023-01-26T20:07:43Z

Lists: pgsql-hackers

Nathan Bossart <nathandbossart@gmail.com> writes:
> On Thu, Jan 26, 2023 at 02:42:05PM -0500, Robert Haas wrote:
>> Basically my question is whether having one error message for all of
>> those cases is good enough, or whether we should be trying harder.

I think the password case needs to be kept separate, because the
conditions for it are different (specifically the exception that
you can alter your own password).  Lumping the rest together
seems OK to me.

			regards, tom lane

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Improve several permission-related error messages.
- de4d456b406b 16.0 landed
Integrate superuser check into has_rolreplication()
- 442f8700656b 16.0 landed
Small code simplification
- 3b7cd8c690f2 16.0 landed
Adjust interaction of CREATEROLE with role properties.
- f1358ca52dd7 16.0 landed
Add new GUC reserved_connections.
- 6e2775e4d4e4 16.0 landed
Rename ReservedBackends variable to SuperuserReservedConnections.
- fe00fec1f5d7 16.0 landed
Update docs and error message for superuser_reserved_connections.
- 6c1d5ba48678 16.0 landed
Add new GUC createrole_self_grant.
- e5b8a4c098ad 16.0 cited
Restrict the privileges of CREATEROLE users.
- cf5eb37c5ee0 16.0 cited
Add a SET option to the GRANT command.
- 3d14e171e9e2 16.0 cited