Re: Why does pgindent's README say to download typedefs.list from the buildfarm?
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: pgsql-hackers@postgresql.org
Date: 2024-04-22T20:08:08Z
Lists: pgsql-hackers
Nathan Bossart <nathandbossart@gmail.com> writes: > I used to do this step when I first started hacking on Postgres because > that's what it says to do, but I've only ever used the in-tree one for many > years now, and I'm not aware of any scenario where I might need to download > a new version from the buildfarm. I see that the in-tree copy wasn't added > until 2010 (commit 1604057), so maybe this is just leftover from back then. > Could we remove this note now? I think the actual plan now is that we'll sync the in-tree copy with the buildfarm's results (and then do a tree-wide pgindent) every so often, probably shortly before beta every year. The problem with the README is that it describes that process, rather than the now-typical workflow of incrementally keeping the tree indented. I don't think we want to remove the info about how to do the full-monty process, but you're right that the README needs to explain the incremental method as being the one most developers would usually use. Want to write some text? regards, tom lane
Commits
-
Sync typedefs.list with buildfarm, for real this time.
- 70353e463cd3 17.0 landed
-
Remove unused typedefs
- be5942aee7a0 17.0 landed
-
Remove enum WaitEventExtension
- 110eb4aefbad 17.0 landed
-
Add pgindent typedefs file to CVS.
- 16040575a044 9.0.0 cited