Horton
Menu

Re: Change copyObject() to use typeof_unqual

Tom Lane <tgl@sss.pgh.pa.us>

View thread
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Masahiko Sawada <sawada.mshk@gmail.com>
Cc: Jelte Fennema-Nio <postgres@jeltef.nl>, Peter Eisentraut <peter@eisentraut.org>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2026-03-17T02:39:29Z
Lists: pgsql-hackers 
Masahiko Sawada <sawada.mshk@gmail.com> writes:
> I'm still encountering the following error while building from source
> at commit f4af7849b3d when using autoconf:

> execParallel.c:154:9: error: call to undeclared function
> 'typeof_unqual'; ISO C99 and later do not support implicit function
> declarations [-Wimplicit-function-declaration]
>   154 |         plan = copyObject(plan);
>       |                ^

> I'm using Fedora 43 and gcc (GCC) 15.2.1 20260123 (Red Hat 15.2.1-7).

Ugh, yeah, reproduced here.  FTR, this platform has

$ gcc --version
gcc (GCC) 15.2.1 20260123 (Red Hat 15.2.1-7)
$ clang --version
clang version 21.1.8 (Fedora 21.1.8-4.fc43)

While this version of clang doesn't like typeof_unqual, it does take
__typeof_unqual__.  So maybe we were premature to decide that we
could prefer the typeof_unqual spelling.  I can get it to build
if I use __typeof_unqual__.

> The issue doesn't happen when using meson+ninja.

Per upthread, we don't have bitcode compilation working in the
meson buildsystem, so we aren't trying to invoke clang in that
case.

			regards, tom lane

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Add some const qualifiers enabled by typeof_unqual change on copyObject

  2. Hardcode typeof_unqual to __typeof_unqual__ for clang

  3. Clean up postgres_fdw/t/010_subscription.pl.

  4. Hardcode override of typeof_unqual for clang-for-bitcode

  5. Make typeof and typeof_unqual fallback definitions work on C++11

  6. Change copyObject() to use typeof_unqual

  7. Fixes for C++ typeof implementation

  8. Support using copyObject in standard C++