Re: WIP Incremental JSON Parser

Andrew Dunstan <andrew@dunslane.net>

From: Andrew Dunstan <andrew@dunslane.net>

To: Nathan Bossart <nathandbossart@gmail.com>

Cc: Jelte Fennema-Nio <postgres@jeltef.nl>, Tom Lane <tgl@sss.pgh.pa.us>, Amit Langote <amitlangote09@gmail.com>, Jacob Champion <jacob.champion@enterprisedb.com>, Robert Haas <robertmhaas@gmail.com>, Peter Smith <smithpb2250@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>

Date: 2024-04-05T14:15:45Z

Lists: pgsql-hackers

Attachments

fix_lex_number2.patch (text/x-patch) patch

On 2024-04-04 Th 15:54, Nathan Bossart wrote:
> On Thu, Apr 04, 2024 at 03:31:12PM -0400, Andrew Dunstan wrote:
>> Does the attached patch fix it for you?
> It clears up 2 of the 3 warnings for me:
>
> ../postgresql/src/common/jsonapi.c: In function ‘IsValidJsonNumber’:
> ../postgresql/src/common/jsonapi.c:2018:30: error: ‘dummy_lex.inc_state’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
>   2018 |  if (lex->incremental && !lex->inc_state->is_last_chunk &&
>        |
>

Thanks, please try this instead.


cheers


andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com

Commits

Post review fixes for test_json_parser test module
- ba3e6e2bca97 17.0 landed
Shrink test file for test_json_parser module
- b8a7bfa33324 17.0 landed
Add support for incrementally parsing backup manifests
- ea7b4e9a2a7c 17.0 landed
Introduce a non-recursive JSON parser
- 3311ea86edc7 17.0 landed
Use incremental parsing of backup manifests.
- 222e11a10ae9 17.0 landed