Re: meson: Optionally disable installation of test modules

On 23.02.23 19:06, Nazir Bilal Yavuz wrote:
> Hi,
> 
> Thanks for the review.
> 
> On Mon, 20 Feb 2023 at 21:44, Peter Eisentraut
> <peter.eisentraut@enterprisedb.com> wrote:
>>
>> I tested this a bit.  It works fine.  The approach makes sense to me.
>>
>> The install_additional_files script could be simplified a bit.  You
>> could use os.makedirs(dest, exist_ok=True) and avoid the error checking.
>>     I don't think any callers try to copy a directory source, so the
>> shutil.copytree() stuff isn't necessary.  Run pycodestyle over the
>> script.  And let's put the script into src/tools/ like the other support
>> scripts.
>>
> 
> I updated the patch in line with your comments.

Looks good to me.  I did a small pass over it to adjust some namings. 
For example, I renamed test_install_files to test_install_data, so it's 
consistent with the overall meson naming:

-install_data(
+test_install_data += files(

Let me know if you have any concerns about this version.  Otherwise, I'm 
happy to commit it.