Horton

Re: jsonapi: scary new warnings with LTO enabled

Daniel Gustafsson <daniel@yesql.se>

View thread View on postgr.es
From: Daniel Gustafsson <daniel@yesql.se>
To: Jacob Champion <jacob.champion@enterprisedb.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Date: 2025-04-23T09:35:15Z
Lists: pgsql-hackers 
> On 23 Apr 2025, at 02:01, Jacob Champion <jacob.champion@enterprisedb.com> wrote:
> On Tue, Apr 22, 2025 at 3:10 AM Daniel Gustafsson <daniel@yesql.se> wrote:

>> The attached
>> v3 allocates via the JSON api, no specific error handling should be required as
>> it's already handled today.
> 
> pgindent shows one whitespace change on my machine (comment
> indentation), but other than that, LGTM! Fuzzers are happy too.

Thanks for confirming, I've pushed this now.

--
Daniel Gustafsson

Commits

  1. Allocate JsonLexContexts on the heap to avoid warnings