Horton

Re: [PATCH] Honor PG_TEST_NOCLEAN for tempdirs

Daniel Gustafsson <daniel@yesql.se>

View thread View on postgr.es
From: Daniel Gustafsson <daniel@yesql.se>
To: Michael Paquier <michael@paquier.xyz>
Cc: Jacob Champion <jchampion@timescale.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2023-06-27T06:10:42Z
Lists: pgsql-hackers 
> On 27 Jun 2023, at 07:47, Michael Paquier <michael@paquier.xyz> wrote:
> 
> On Mon, Jun 26, 2023 at 04:55:47PM -0700, Jacob Champion wrote:
>> I was running the test_pg_dump extension suite, and I got annoyed that
>> I couldn't keep it from deleting its dump artifacts after a successful
>> run. Here's a patch to make use of PG_TEST_NOCLEAN (which currently
>> covers the test cluster's base directory) with the Test::Utils
>> tempdirs too.
> 
> I am still +1 in doing that.
> 
>> (Looks like this idea was also discussed last year [1]; let me know if
>> I missed any more recent suggestions.)

+1.  I think it simply got lost in that thread which had a lot of moving parts
as it was.

--
Daniel Gustafsson

Commits

  1. Make PG_TEST_NOCLEAN work for temporary directories in TAP tests