Re: Rethinking opclass member checks and dependency strength
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Alexander Korotkov <a.korotkov@postgrespro.ru>,
PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2020-03-31T21:19:29Z
Lists: pgsql-hackers
Alvaro Herrera <alvherre@2ndquadrant.com> writes: > On 2019-Aug-18, Tom Lane wrote: >> * I'm not at all impressed with the name, location, or concept of >> opfam_internal.h. I think we should get rid of that header and put >> the OpFamilyMember struct somewhere else. Given that this patch >> makes it part of the AM API, it wouldn't be unreasonable to move it >> to amapi.h. But I've not done that here. > I created that file so that it'd be possible to interpret the struct > when dealing with DDL commands in event triggers (commit b488c580aef4). > The struct was previously in a .c file, and we didn't have an > appropriate .h file to put it in. I think amapi.h is a great place for > it. Yeah, later versions of the patch put it there. regards, tom lane
Commits
-
Invent "amadjustmembers" AM method for validating opclass members.
- 9f9682783bea 14.0 landed
-
Allow on-the-fly capture of DDL event details
- b488c580aef4 9.5.0 cited