Horton

Re: Unused header file inclusion

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>, vignesh C <vignesh21@gmail.com>, Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2019-08-19T22:09:55Z
Lists: pgsql-hackers 
Andres Freund <andres@anarazel.de> writes:
> On 2019-08-19 13:07:50 -0700, Andres Freund wrote:
>> On 2019-08-18 14:37:34 -0400, Tom Lane wrote:
>>> Oddly, cpluspluscheck does not complain about those cases, but it
>>> does complain about

>> Hm. I don't understand why it's not complaining. Wonder if it's a
>> question of the flags or such.

> I'ts caused by -fsyntax-only

Ah-hah.  Should we change that to something else?  That's probably
a hangover from thinking that all we had to do was check for C++
keywords.

>> I wish we could move the whole logic of those scripts into makefiles, so
>> we could employ parallelism.

I can't really get excited about expending a whole bunch of additional
work on these scripts.

			regards, tom lane

Commits

  1. Add fmgr.h include to selfuncs.h.

  2. Add "headerscheck" script to test header-file compilability under C.

  3. Fix failure-to-compile-standalone in scripts_parallel.h.

  4. Remove fmgr.h includes from headers that don't really need it.

  5. Don't include utils/array.h from acl.h.

  6. Remove redundant prototypes for SQL callable functions.

  7. Remove unnecessary #include <limits.h>

  8. Teach tuplesort.c about "top N" sorting, in which only the first N tuples