Re: filenames in pg_basebackup

Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> I notice that pg_basebackup has lots of messages where file names are
> not in quotes.  Is this okay?

They should be in double quotes, per our message style guidelines.

> msgid "%s: segment file '%s' is incorrect size %d, skipping\n"
> I also wonder about "is" vs. "has" in the above message.

Yeah, "has" would be more correct.

> Apparently, this needs a thorough revision ...

Evidently.  Peter tends to see to that sort of thing while he works on
translations, but I'm sure he wouldn't mind some help.

			regards, tom lane