Horton

Re: A few warnings on Windows

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Thomas Munro <thomas.munro@enterprisedb.com>
Cc: Michael Paquier <michael@paquier.xyz>, Pg Hackers <pgsql-hackers@postgresql.org>, chris@chrullrich.net
Date: 2018-05-02T21:13:49Z
Lists: pgsql-hackers 
Thomas Munro <thomas.munro@enterprisedb.com> writes:
> One more problem.  whelk builds against Python 3.6 and says:

> c:\users\pgbf\appdata\local\programs\python\python36-32\include\pyconfig.h(174):
> warning C4142: benign redefinition of type
> (src/pl/plpython/plpy_elog.c)
> [C:\buildfarm\buildenv\HEAD\pgsql.build\plpython3.vcxproj]

> Does anyone know what line 174 of pyconfig.h happens to say?

We'll have to ask the machine's owner I guess (cc'd here).
In the python 3.6 installation I have at hand, there's nothing
except #define's in pyconfig.h ... but the Windows version must
do things differently.

			regards, tom lane

Commits

  1. Suppress some compiler warnings in plperl on Windows.

  2. Fix compiler warning on Windows.

  3. Change SIZEOF_BOOL to 1 for Windows.

  4. Fix some assorted compiler warnings on Windows.

  5. Clean up warnings from -Wimplicit-fallthrough.