Re: jsonb crash
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: David Rowley <dgrowleyml@gmail.com>
Cc: David Rowley <drowley@postgresql.org>,
Jaime Casanova <jcasanov@systemguards.com.ec>,
PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2021-09-29T21:09:48Z
Lists: pgsql-hackers
David Rowley <dgrowleyml@gmail.com> writes: > On Thu, 30 Sept 2021 at 09:24, Tom Lane <tgl@sss.pgh.pa.us> wrote: >> After further inspection, "what are we doing in jsonb_hash?" is >> indeed a relevant question, but it seems like it's a type mismatch >> not a nullness issue. EXPLAIN VERBOSE shows > I think you're right here. It should be hashing text. That seems to > be going wrong in check_memoizable() because it assumes it's always > fine to use the left side's type of the OpExpr to figure out the hash > function to use. > Maybe we can cache the left and the right type's hash function and use > the correct one in paraminfo_get_equal_hashops(). Um ... it seems to have correctly identified the cache key expressions, so why isn't it just doing exprType on those? The jsonb_exists operator seems entirely irrelevant here. regards, tom lane
Commits
-
Allow Memoize to operate in binary comparison mode
- 6c32c0977783 14.2 landed
- e502150f7d0b 15.0 landed
-
Fix incorrect hash equality operator bug in Memoize
- 1f194ed6c26e 14.1 landed
- 39a3105678a2 15.0 landed