Horton

Re: potential stuck lock in SaveSlotToPath()

Peter Eisentraut <peter.eisentraut@2ndquadrant.com>

View thread View on postgr.es
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Robert Haas <robertmhaas@gmail.com>, pgsql-hackers <pgsql-hackers@postgresql.org>, Andres Freund <andres@anarazel.de>, Alvaro Herrera <alvherre@2ndquadrant.com>
Date: 2020-04-05T08:13:44Z
Lists: pgsql-hackers 
On 2020-04-02 08:21, Michael Paquier wrote:
> On Wed, Apr 01, 2020 at 04:26:25PM +0200, Peter Eisentraut wrote:
>> Good catch.  How about the attached patch?
> 
> WFM.  Another trick would be to call LWLockRelease() after generating
> the log, but I find your patch more consistent with the surroundings.

done

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Commits

  1. Drop slot's LWLock before returning from SaveSlotToPath()