Horton

Re: Underscore in positional parameters?

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter@eisentraut.org>
Cc: Erik Wienhold <ewie@ewie.name>, Alexander Lakhin <exclusion@gmail.com>, Michael Paquier <michael@paquier.xyz>, Dean Rasheed <dean.a.rasheed@gmail.com>, pgsql-hackers@postgresql.org
Date: 2024-07-02T14:14:48Z
Lists: pgsql-hackers 
Peter Eisentraut <peter@eisentraut.org> writes:
> I had to revert the test case from the 0002 patch.  It ended up running 
> some build farm machines out of memory.

That ties into what I said upthread: why are we involving MaxAllocSize
in this at all?  The maximum parameter number you can actually use in
extended queries is 65535 (because 16-bit fields), and I can't see a
good reason to permit more.

			regards, tom lane

Commits

  1. Fix overflow in parsing of positional parameter

  2. Limit max parameter number with MaxAllocSize

  3. Re-forbid underscore in positional parameters