Horton

Re: invalid data in file backup_label problem on windows

David Steele <david@pgmasters.net>

View thread View on postgr.es
From: David Steele <david@pgmasters.net>
To: Magnus Hagander <magnus@hagander.net>, Michael Paquier <michael@paquier.xyz>
Cc: Andrew Dunstan <andrew@dunslane.net>, "wangsh.fnst@fujitsu.com" <wangsh.fnst@fujitsu.com>, "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
Date: 2021-03-31T13:33:25Z
Lists: pgsql-hackers

Attachments

On 3/29/21 4:34 AM, Magnus Hagander wrote:
> On Mon, Mar 29, 2021 at 7:01 AM Michael Paquier <michael@paquier.xyz> wrote:
>>
>> On Sun, Mar 28, 2021 at 09:29:10AM -0400, Andrew Dunstan wrote:
>>> -     vital to the backup working, and must be written without modification.
>>> +     vital to the backup working and must be written without
>>> modification, which
>>> +     may include opening the file in binary mode.
>>
>> += "on Windows"?
> 
> I'd say no, better to just tell people to always open the file in
> binary mode. It's not hurtful anywhere, there's really no reason ever
> to open it in text mode.

Agreed. New patch attached.

Regards,
-- 
-David
david@pgmasters.net

Commits

  1. doc: Clarify how to generate backup files with non-exclusive backups