Horton

Re: Missing [NO] INDENT flag in XMLSerialize backward parsing

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
Cc: Jim Jones <jim.jones@uni-muenster.de>, Andrew Dunstan <andrew@dunslane.net>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Pavel Stehule <pavel.stehule@gmail.com>
Date: 2025-02-21T14:53:06Z
Lists: pgsql-hackers 
Michael Paquier <michael@paquier.xyz> writes:
> On Fri, Feb 21, 2025 at 12:29:12PM +0100, Jim Jones wrote:
>> For future reference, what’s the best way to verify this myself? The
>> buildfarm was all green.

> Don't worry, we are all trapped by that at some point.

Yeah, I leave that to the buildfarm too.

If I have to actually debug or test behavior touching this, I use a
non-reporting buildfarm instance that I have lying around, which is
configured to run the cross-version tests and not very much else.
I can switch that between pulling source from the community repo
and pulling from a local checkout that has the mods I want to test.

			regards, tom lane

Commits

  1. Fix cross-version upgrades with XMLSERIALIZE(NO INDENT)

  2. Add missing deparsing of [NO] IDENT to XMLSERIALIZE()