Horton

Re: ISN extension - wrong volatility level for isn_weak() function

Tom Lane <tgl@sss.pgh.pa.us>

View thread
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Viktor Holmberg <v@viktorh.net>
Cc: Daniel Gustafsson <daniel@yesql.se>, pgsql-bugs@lists.postgresql.org
Date: 2025-03-14T15:13:49Z
Lists: pgsql-bugs

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. contrib/isn: Make weak mode a GUC setting, and fix related functions.

  2. Update contrib/seg for new scalarlesel/scalargesel selectivity functions.

Viktor Holmberg <v@viktorh.net> writes:
> I haven’t checked the source code, but yes the isn_weak feature has some footgun potential. As it doesn’t respect transactions, but rather sets a flag on session level, it’s easy for the “isn weakness” to leak out into a connection pool.

Yeah, really that ought to be a GUC I should think.  There isn't
anything well-designed about it ...

I found some prior discussion here:

https://www.postgresql.org/message-id/flat/C12AE0A2A752416C79F3EE81%40teje

but we don't seem to have pulled the trigger on changing anything.

			regards, tom lane