Re: BUG #16171: Potential malformed JSON in explain output
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: Hamid Akhtar <hamid.akhtar@gmail.com>, pgsql-hackers@lists.postgresql.org
Date: 2020-02-03T15:56:09Z
Lists: pgsql-bugs, pgsql-hackers
Attachments
- 0002-check-json-validity-2.patch (text/x-diff) patch 0002
Daniel Gustafsson <daniel@yesql.se> writes: > On 1 Feb 2020, at 20:37, Tom Lane <tgl@sss.pgh.pa.us> wrote: >> 0002 attached isn't committable, because nobody would want the overhead >> in production, but it seems like a good trick to keep up our sleeves. > Thats a neat trick, I wonder if it would be worth maintaining a curated list of > these tricks in a README under src/test to help others avoid/reduce wheel > reinventing? It occurred to me that as long as this is an uncommittable hack anyway, we could feed the EXPLAIN data to jsonb_in and then hot-wire the jsonb code to whine about duplicate keys. So attached, for the archives' sake, is an improved version that does that. I still don't find any problems (other than the one we're fixing here); though no doubt if I reverted 100136849 it'd complain about that. regards, tom lane
Commits
-
Fix handling of "Subplans Removed" field in EXPLAIN output.
- 9a85860e12aa 12.2 landed
- 842a23efa92a 11.7 landed
- 7d91b604d9b5 13.0 landed
-
Doc: Fix list of storage parameters available for ALTER TABLE
- c4c76d198e3d 12.2 cited