Re: lock_timeout GUC patch
Jaime Casanova <jcasanov@systemguards.com.ec>
From: Jaime Casanova <jcasanov@systemguards.com.ec>
To: Boszormenyi Zoltan <zb@cybertec.at>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, pgsql-hackers@postgresql.org, Robert Haas <robertmhaas@gmail.com>, Jeff Janes <jeff.janes@gmail.com>, Alvaro Herrera <alvherre@commandprompt.com>, Bruce Momjian <bruce@momjian.us>, Hans-Juergen Schoenig <postgres@cybertec.at>, Josh Berkus <josh@agliodbs.com>, Sándor Miglécz <sandor@cybertec.at>, Andres Freund <andres@anarazel.de>
Date: 2010-01-13T06:14:05Z
Lists: pgsql-hackers
2010/1/13 Boszormenyi Zoltan <zb@cybertec.at>: > Tom Lane írta: >> >> If this patch is touching those parts of relcache.c, it probably needs >> rethinking. >> > > What I did there is to check the return value of LockRelationOid() the hunk was because a diference in the position (i guess patch accept a hunk of reasonable size, assuming there is something like a reasonable size for that) and is not touching the same as your refactor (sorry if i explain myself bad) > and also elog(PANIC) if the lock wasn't available. > Does it need rethinking? > well, i actually think that PANIC is too high for this... -- Atentamente, Jaime Casanova Soporte y capacitación de PostgreSQL Asesoría y desarrollo de sistemas Guayaquil - Ecuador Cel. +59387171157