Horton

Accidental setting of XLogReaderState.private_data ?

Antonin Houska <ah@cybertec.at>

View thread View on postgr.es
From: Antonin Houska <ah@cybertec.at>
To: pgsql-hackers@postgresql.org
Date: 2019-04-15T11:51:34Z
Lists: pgsql-hackers

Attachments

StartupDecodingContext() initializes ctx->reader->private_data with ctx, and
it even does so twice. I couldn't find a place in the code where the
(LogicalDecodingContext *) pointer is retrieved from the reader, and a simple
test of logical replication works if the patch below is applied. Thus I assume
that assignment is a thinko, isn't it?

-- 
Antonin Houska
Web: https://www.cybertec-postgresql.com

Commits

  1. Remove duplicate assignment when initializing logical decoder context