Horton
Menu

Re: BUG #18850: REDUNDANT_COMPARISON.ALWAYS_FALSE Redundant comparison

Tom Lane <tgl@sss.pgh.pa.us>

View thread
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pm91.arapov@gmail.com
Cc: pgsql-bugs@lists.postgresql.org
Date: 2025-03-14T14:32:04Z
Lists: pgsql-bugs 
PG Bug reporting form <noreply@postgresql.org> writes:
> REDUNDANT_COMPARISON.ALWAYS_FALSE Redundant comparison

Let's see, in #18848 and #18849 you were complaining about
non-robust code, but here you want to remove robustness?
I think it's fine as-is.  (The back story here is that we
used to support postfix operators, so the earlier error
for !OidIsValid(typeId2) postdates this bit.  While I don't
think that support is ever coming back, I'm disinclined to
remove a couple of lines that would be important for it.)

			regards, tom lane