Horton

Re: cpluspluscheck complains about use of register

Tom Lane <tgl@sss.pgh.pa.us>

View thread
From: Tom Lane <tgl@sss.pgh.pa.us>
To: "Tristan Partin" <tristan@partin.io>
Cc: "Christoph Berg" <myon@debian.org>, "Andres Freund" <andres@anarazel.de>, pgsql-hackers@postgresql.org, "Fabien COELHO" <coelho@cri.ensmp.fr>
Date: 2024-10-25T20:19:25Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Remove uses of register due to incompatibility with C++17 and up

"Tristan Partin" <tristan@partin.io> writes:
> FWIW, I ran into this compiling an extension written in C++ for v15, so 
> I'll throw my support for backpatching this if that is still on the 
> table. Understandable if not, though.

I'm inclined to think "too late".  Even if we back-patched to v15
and earlier now, your extension would probably still want to be
compilable against earlier minor releases, so the back-patch
would not help you a lot.  Christoph's workaround of
"#define register" is probably the best answer for old PG versions,
or you can compile with "-Wno-register".

			regards, tom lane