Horton
Menu

Re: BUG #18845: DEREF_OF_NULL.RET guc_malloc possibly returns NULL

Tom Lane <tgl@sss.pgh.pa.us>

View thread
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: pm91.arapov@gmail.com, pgsql-bugs@lists.postgresql.org
Date: 2025-03-14T14:04:59Z
Lists: pgsql-bugs 
Daniel Gustafsson <daniel@yesql.se> writes:
> Why would we want FATAL here?  Wouldn't it be better to return false like how
> other check_ functions already do?

Indeed.  Also, a quick survey shows a lot of inconsistency in
guc_malloc callers --- some are lazy and just use ERROR rather
than LOG-and-return.  That's probably all right for PGC_POSTMASTER
variables (since there's no chance of continuing anyway) but
perhaps it's worth improving elsewhere.

			regards, tom lane

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Fix guc_malloc calls for consistency and OOM checks