Re: cross-platform pg_basebackup
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
Cc: "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Date: 2022-10-20T16:17:12Z
Lists: pgsql-hackers
Robert Haas <robertmhaas@gmail.com> writes: > However, I think we could relax the check a little bit, something > along the lines of !is_nonwindows_absolute_path(cell->old_dir) && > !is_windows_absolute_path(dir). We can't actually know whether the > remote side is Windows or non-Windows, but if the string we're given > is plausibly an absolute path under either set of conventions, it's > probably fine to just search the list for it and see if it shows up. Seems reasonable. > This would have the disadvantage that if a Linux user creates a > tablespace directory inside $PGDATA and gives it a name like > /home/rhaas/pgdata/C:\Program Files\PostgreSQL\Data, and then attempts > a backup with '-TC:\Program Files\PostgreSQL\Data=/tmp/ts1' it will > not relocate the tablespace, yet the user won't get a message > explaining why. I'm prepared to dismiss that scenario as "not a real > use case". Agreed. regards, tom lane
Commits
-
pg_basebackup: Fix cross-platform tablespace relocation.
- ba58266eb8db 10.23 landed
- 38214dabd425 11.18 landed
- 475e9daf3979 12.13 landed
- 0bf2cd1602b1 13.9 landed
- aaad8adb02ed 14.6 landed
- 5c013e620c91 15.1 landed
- 1f0c4fa25525 16.0 landed