Re: Curious test case added by collation version tracking patch
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: Julien Rouhaud <rjuju123@gmail.com>,
PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2021-04-12T22:47:04Z
Lists: pgsql-hackers
Thomas Munro <thomas.munro@gmail.com> writes: > On Tue, Apr 13, 2021 at 8:59 AM Tom Lane <tgl@sss.pgh.pa.us> wrote: >> The reason I ask is that this case started failing after I fixed >> a parse_coerce.c bug that allowed a CollateExpr node to survive >> in this WHERE expression, which by rights it should not. I'm >> inclined to think that the test case is wrong and should be removed, >> but maybe there's some reason to have a variant of it. > Indeed, this doesn't do anything useful, other than prove that we > record a collation dependency where it is (uselessly) allowed in an > expression. Since you're not going to allow that anymore, it should > be dropped. OK, I'll go clean it up. Thanks! regards, tom lane
Commits
-
Remove no-longer-relevant test case.
- cf0020080a3d 14.0 landed
-
Track collation versions for indexes.
- 257836a75585 14.0 cited