Re: Fix typo with logical connector (src/backend/commands/vacuumparallel.c)
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Ranier Vilela <ranier.vf@gmail.com>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2022-08-19T13:28:19Z
Lists: pgsql-hackers
Ranier Vilela <ranier.vf@gmail.com> writes: > At function parallel_vacuum_process_all_indexes there is > a typo with a logical connector. > I think that correct is &&, because both of the operators are > bool types [1]. > As a result, parallel vacuum workers can be incorrectly enabled. Since they're bools, the C spec requires them to promote to integer 0 or 1, therefore the & operator will yield the desired result. So there's not going to be any incorrect behavior. Nonetheless, I agree that && would be better, because it would short-circuit the evaluation of parallel_vacuum_index_is_parallel_safe() when there's no need. regards, tom lane
Commits
-
Use logical operator && instead of & in vacuumparallel.c.
- 838f798f172d 16.0 landed
- 254d79f0b23d 15.0 landed