Re: BUG #18297: Error when adding a column to a parent table with complex inheritance
Alexander Law <exclusion@gmail.com>
From: Alexander Lakhin <exclusion@gmail.com>
To: Tender Wang <tndrwang@gmail.com>
Cc: Richard Guo <guofenglinux@gmail.com>, pgsql-bugs@lists.postgresql.org
Date: 2024-01-22T17:00:01Z
Lists: pgsql-bugs
Hi, 22.01.2024 13:36, Tender Wang wrote: > > Yes, I've encountered a similar issue, this time with ALTER (TEXT SEARCH > CONFIGURATION): > CREATE TEXT SEARCH CONFIGURATION ispell_tst (COPY=english); > CREATE TEXT SEARCH DICTIONARY ispell (Template=ispell, DictFile=ispell_sample, AffFile=ispell_sample); > ALTER TEXT SEARCH CONFIGURATION ispell_tst ALTER MAPPING FOR word, word WITH ispell; > ERROR: tuple already updated by self > > > Yes, this is another issue that DDL operation on an same object twice. Maybe we can report error on Parse phase. > But as you say, all the other DDL commands run OK, so maybe it's better to process this case in execution phase. > I will send a patch later. Thank you for working on this! As these two cases look like exceptions to the common behavior, I wonder whether we need some extra functions to deal with duplicates. (I haven't look yet how such duplicates processed for other object types.) > > And I'm just curious that how do you find these issues? Use some tools? I discovered these two issues with my kind of fuzzer, just watching out for the interesting errors. Best regards, Alexander
Commits
-
Fix ALTER TABLE .. ADD COLUMN with complex inheritance trees
- 2f724283719e 12.18 landed
- bfec14d06de8 13.14 landed
- 5a7833f49679 14.11 landed
- ad6fbbeeb07a 15.6 landed
- 51193e7a7d33 16.2 landed
- bb812ab0917e 17.0 landed