Re: pg_walsummary, Character-not-present-in-option

I forgot to attach the patch file, so I'm attaching it in reply．


2024-09-30 15:02 に btsugieyuusuke さんは書きました:
> Hi hackers,
> I found probably something to fix in pg_walsummary.
> 
> pg_walsummary specifies “f:iqw:” as the third argument of 
> getopt_long().
> 
>> /* process command-line options */
>> while ((c = getopt_long(argc, argv, "f:iqw:",
>> 				long_options, &optindex)) != -1)
> 
> However, only i and q are valid options.
> 
>> 	switch (c)
>> 	{
>> 		case 'i':
>> 			break;
>> 		case 'q':
>> 			opt.quiet = true;
>> 			break;
>> 		default:
>> 			/* getopt_long already emitted a complaint */
>> 			pg_log_error_hint("Try \"%s --help\" for more information.", 
>> progname);
>> 			exit(1);
>> 	}
> 
> Therefore, shouldn't “f:” and “w:” be removed?
> 
> Best regards,
> Yusuke Sugie