Re: TRUNCATE on foreign table
Fujii Masao <masao.fujii@oss.nttdata.com>
From: Fujii Masao <masao.fujii@oss.nttdata.com>
To: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Cc: Kohei KaiGai <kaigai@heterodb.com>, Kazutaka Onishi
<onishi@heterodb.com>, Zhihong Yu <zyu@yugabyte.com>,
Amit Langote <amitlangote09@gmail.com>, Ibrar Ahmed <ibrar.ahmad@gmail.com>,
PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>,
Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
Date: 2021-04-16T02:54:16Z
Lists: pgsql-hackers
Attachments
- truncate_foreign_table_dont_pass_only_clause.patch (text/plain) patch
On 2021/04/16 9:15, Bharath Rupireddy wrote: > On Thu, Apr 15, 2021 at 8:19 PM Fujii Masao <masao.fujii@oss.nttdata.com> wrote: >> On 2021/04/14 12:54, Bharath Rupireddy wrote: >>> IMHO, we can push all the TRUNCATE options (ONLY, RESTRICTED, CASCADE, >>> RESTART/CONTINUE IDENTITY), because it doesn't have any major >>> challenge(implementation wise) unlike pushing some clauses in >>> SELECT/UPDATE/DELETE and we already do this on the master. It doesn't >>> look good and may confuse users, if we push some options and restrict >>> others. We should have an explicit note in the documentation saying we >>> push all these options to the remote server. We can leave it to the >>> user to write TRUNCATE for foreign tables with the appropriate >>> options. If somebody complains about a problem that they will face >>> with this behavior, we can revisit. >> >> That's one of the options. But I'm afraid it's hard to drop (revisit) >> the feature once it has been released. So if there is no explicit >> use case for that, basically I'd like to drop that before release >> like we agree to drop unused TRUNCATE_REL_CONTEXT_CASCADING. > > Thanks. Looks like the decision is going in the direction of > restricting those options, I will withdraw my point. We are still discussing whether RESTRICT option should be pushed down to a foreign data wrapper. But ISTM at least we could reach the consensus about the drop of extra information for each foreign table. So what about applying the attached patch and remove the extra information at first? Regards, -- Fujii Masao Advanced Computing Technology Center Research and Development Headquarters NTT DATA CORPORATION
Commits
-
doc: Review for "Allow TRUNCATE command to truncate foreign tables".
- 0c8f40863acb 14.0 landed
-
Don't pass "ONLY" options specified in TRUNCATE to foreign data wrapper.
- 8e9ea08bae93 14.0 landed
-
Support tab-complete for TRUNCATE on foreign tables.
- 81e094bdfdd6 14.0 landed
-
Allow TRUNCATE command to truncate foreign tables.
- 8ff1c94649f5 14.0 landed
-
Add support for asynchronous execution.
- 27e1f14563cf 14.0 cited