Horton

Re: renumber_oids.pl needs some updates

Peter Eisentraut <peter.eisentraut@enterprisedb.com>

View thread View on postgr.es
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: Tom Lane <tgl@sss.pgh.pa.us>, pgsql-hackers@lists.postgresql.org
Cc: John Naylor <john.naylor@enterprisedb.com>
Date: 2022-04-20T20:56:53Z
Lists: pgsql-hackers 
On 20.04.22 22:45, Tom Lane wrote:
> I think the right way to fix #2 is to put the responsibility for
> generating the #define's into genbki.pl, instead of this mistake-prone
> approach of duplicating the OID constants in the source code.
> 
> The attached proposed patch invents a variant macro
> DECLARE_TOAST_WITH_MACRO for the relatively small number of cases
> where we need such OID macros.

This makes sense.

A more elaborate (future) project would be to have genbki.pl generate 
all of IsSharedRelation(), which is the only place these toast-table-OID 
macros are used, AFAICT.

Commits

  1. Use DECLARE_TOAST_WITH_MACRO() to simplify toast-table declarations.

  2. Add primary keys and unique constraints to system catalogs