Re: row filtering for logical replication
Tomas Vondra <tomas.vondra@enterprisedb.com>
Commits
GET /api/v1/messages/:b64id/commits
the thread's linked commits as JSON, with link sources.
API reference →
-
Release cache tuple when no longer needed
- ed0fbc8e5ac9 15.0 landed
-
Add some additional tests for row filters in logical replication.
- ceb57afd3ce1 15.0 landed
-
Fix one of the tests introduced in commit 52e4f0cd47.
- cfb4e209ec15 15.0 landed
-
Allow specifying row filters for logical replication of tables.
- 52e4f0cd472d 15.0 landed
-
Move scanint8() to numutils.c
- cfc7191dfea3 15.0 cited
-
Replace Test::More plans with done_testing
- 549ec201d613 15.0 cited
-
Reduce relcache access in WAL sender streaming logical changes
- 6ce16088bfed 15.0 cited
-
Small cleanups related to PUBLICATION framework code
- c9105dd3660f 15.0 cited
-
Add a view to show the stats of subscription workers.
- 8d74fc96db5f 15.0 cited
-
Allow publishing the tables of schema.
- 5a2832465fd8 15.0 cited
-
Doc: improve documentation of CREATE/ALTER SUBSCRIPTION.
- 1882d6cca161 15.0 cited
-
Add PublicationTable and PublicationRelInfo structs
- 0c6828fa987b 15.0 cited
-
Remove unused argument "txn" in maybe_send_schema().
- 93d573d86571 15.0 cited
-
Add prepare API support for streaming transactions in logical replication.
- 63cf61cdeb7b 15.0 cited
-
Unify PostgresNode's new() and get_new_node() methods
- 201a76183e20 15.0 cited
-
Use l*_node() family of functions where appropriate
- 2b00db4fb0c7 15.0 cited
-
Add support for prepared transactions to built-in logical replication.
- a8fd13cab0ba 15.0 cited
-
Restore the portal-level snapshot after procedure COMMIT/ROLLBACK.
- ef9480509622 11.13 cited
-
Rename a parse node to be more general
- 91d1f2d30210 14.0 landed
-
Remove unused column atttypmod from initial tablesync query
- 4ad31bb2ef25 14.0 landed
-
SEARCH and CYCLE clauses
- 3696a600e229 14.0 cited
Hi, I see no one responded to this important part of my review so far: On 9/23/21 2:33 PM, Tomas Vondra wrote: > 3) create_subscription.sgml > > <literal>WHERE</literal> clauses, rows must satisfy all expressions > to be copied. If the subscriber is a > > I'm rather skeptical about the principle that all expressions have to > match - I'd have expected exactly the opposite behavior, actually. > > I see a subscription as "a union of all publications". Imagine for > example you have a data set for all customers, and you create a > publication for different parts of the world, like > > CREATE PUBLICATION customers_france > FOR TABLE customers WHERE (country = 'France'); > > CREATE PUBLICATION customers_germany > FOR TABLE customers WHERE (country = 'Germany'); > > CREATE PUBLICATION customers_usa > FOR TABLE customers WHERE (country = 'USA'); > > and now you want to subscribe to multiple publications, because you want > to replicate data for multiple countries (e.g. you want EU countries). > But if you do > > CREATE SUBSCRIPTION customers_eu > PUBLICATION customers_france, customers_germany; > > then you won't get anything, because each customer belongs to just a > single country. Yes, I could create multiple individual subscriptions, > one for each country, but that's inefficient and may have a different > set of issues (e.g. keeping them in sync when a customer moves between > countries). > > I might have missed something, but I haven't found any explanation why > the requirement to satisfy all expressions is the right choice. > > IMHO this should be 'satisfies at least one expression' i.e. we should > connect the expressions by OR, not AND. Am I the only one finding the current behavior strange? What's the reasoning supporting the current approach? regards -- Tomas Vondra EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company