Horton

Re: installcheck-world concurrency issues

Peter Eisentraut <peter.eisentraut@enterprisedb.com>

View thread View on postgr.es
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: Andres Freund <andres@anarazel.de>, pgsql-hackers@postgresql.org
Cc: Peter Geoghegan <pg@bowt.ie>
Date: 2022-10-05T06:16:37Z
Lists: pgsql-hackers 
On 04.10.22 01:41, Andres Freund wrote:
> BTW, shouldn't src/test/modules/unsafe_tests use the PG_TEST_EXTRA mechanism
> somehow?  Seems not great to run it as part of installcheck-world, if we don't
> want to run it as part of installcheck.

I think there are different levels and kinds of unsafeness.  The ssl and 
kerberos tests start open server processes on your machine.  The 
modules/unsafe_tests just make a mess of your postgres instance.  The 
latter isn't a problem when run against a temp instance.

Commits

  1. tests: Rename conflicting role names

  2. tests: Restrict pg_locks queries in advisory_locks.sql to current database