Horton

Re: Why do we have perl and sed versions of Gen_dummy_probes?

Peter Eisentraut <peter.eisentraut@enterprisedb.com>

View thread View on postgr.es
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: Andrew Dunstan <andrew@dunslane.net>, Andres Freund <andres@anarazel.de>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, pgsql-hackers@postgresql.org, Michael Paquier <michael@paquier.xyz>, Craig Ringer <craig.ringer@enterprisedb.com>
Date: 2021-05-10T09:44:44Z
Lists: pgsql-hackers 
On 07.05.21 20:31, Andrew Dunstan wrote:
> On 5/7/21 1:20 PM, Andres Freund wrote:
>> On 2021-05-07 11:19:02 -0400, Andrew Dunstan wrote:
>>> Here's a patch that adds the README and also adds a Makefile recipe for
>>> regenerating Gen_dummy_probes.pl after the sed script is changed. On my
>>> system at least the recipe is idempotent.
>> Nice! Thanks for this work.
> 
> de nada. pushed.

This recipe doesn't produce a Gen_dummy_probes.pl that matches exactly 
the one that is there now.  If this is going to be the preferred method, 
then we should generate it once so that it matches going forward.

Commits

  1. Tweak generation of Gen_dummy_probes.pl

  2. Add a README and Makefile recipe for Gen_dummy_probes.pl

  3. Remove dependency on psed for MSVC builds.