Re: analyze-in-stages post upgrade questions

Laurenz Albe <laurenz.albe@cybertec.at>

From: Laurenz Albe <laurenz.albe@cybertec.at>

To: Mircea Cadariu <cadariu.mircea@gmail.com>, "Zechman, Derek S" <Derek.S.Zechman@snapon.com>, Adrian Klaver <adrian.klaver@aklaver.com>, pgsql-hackers@lists.postgresql.org

Date: 2025-07-11T09:51:30Z

Lists: pgsql-hackers, pgsql-general

Attachments

v2-0001-Make-vacuumdb-Z-process-partitioned-tables.patch (text/x-patch) patch v2-0001

[moving to pgsql-hackers]
On Thu, 2025-07-10 at 17:20 +0100, Mircea Cadariu wrote:
>       I have only one suggestion for the patch. Consider adding a 
> corresponding test in src/bin/scripts/t/100_vacuumdb.pl.
> 
> Proposal (I used this to check the patch):
> 
> $node->safe_psql('postgres',
>      "CREATE TABLE parent_table (a INT) PARTITION BY LIST (a);\n"
>        . "CREATE TABLE child_table PARTITION OF parent_table FOR VALUES 
> IN (1);\n"
>        . "INSERT INTO parent_table VALUES (1);\n");
> $node->issues_sql_like(
>      [
>          'vacuumdb', '--analyze-only', 'postgres'
>      ],
>      qr/statement:\s+ANALYZE\s+public\.parent_table/s,
>      '--analyze_only updates statistics for partitioned tables');

Good idea; done in the attached version 2 of the patch.

Yours,
Laurenz Albe

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

vacuumdb: Make vacuumdb --analyze-only process partitioned tables.
- 6429e5b771db 19 (unreleased) landed
Integrate FullTransactionIds deeper into two-phase code
- 62a17a92833d 19 (unreleased) cited