Horton

Re: POC PATCH: copy from ... exceptions to: (was Re: VLDB Features)

Alena Rybakina <lena.ribackina@yandex.ru>

View thread
From: Alena Rybakina <lena.ribackina@yandex.ru>
To: Damir Belyalov <dam.bel07@gmail.com>, zhihuifan1213@163.com
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Daniel Gustafsson <daniel@yesql.se>, torikoshia <torikoshia@oss.nttdata.com>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>, Andres Freund <andres@anarazel.de>, anisimow.d@gmail.com, HukuToc@gmail.com, Andrey Lepikhov <a.lepikhov@postgrespro.ru>, pgsql-hackers@lists.postgresql.org
Date: 2023-11-14T10:16:35Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. doc: Fix COPY ON_ERROR option syntax synopsis.

  2. Disallow specifying ON_ERROR option without value.

  3. Rename COPY option from SAVE_ERROR_TO to ON_ERROR

  4. Fix spelling in notice

  5. Add new COPY option SAVE_ERROR_TO

Hi!

On 14.11.2023 13:10, Damir Belyalov wrote:
>
>      Here is a very straw-man-level sketch of what I think might work.
>      The option to COPY FROM looks something like
>
>           ERRORS TO other_table_name (item [, item [, ...]])
>
>
> I tried to implement the patch using a table and came across a number 
> of questions.
>
> Which table should we implement for this feature: a system catalog 
> table or store this table as a file or create a new table?
>
> In these cases, security and user rights management issues arise.
> It is better for other users not to see error lines from another user. 
> It is also not clear how access rights to this table are inherited and 
> be given.
>
>
Maybe we can add a guc or a parameter to output such errors during the 
execution of the copy function with errors and check whether the user 
has enough rights to set such a parameter?

That is, I propose to give the user a choice to run copy with and 
without saving errors and at the same time immediately check whether the 
option with error output is possible for him in principle?

-- 
Regards,
Alena Rybakina