Re: Reorganize GUC structs

Peter Eisentraut <peter@eisentraut.org>

View thread View on postgr.es

From: Peter Eisentraut <peter@eisentraut.org>

To: pgsql-hackers <pgsql-hackers@postgresql.org>

Cc: Heikki Linnakangas <hlinnaka@iki.fi>, Álvaro Herrera <alvherre@kurilemu.de>, John Naylor <johncnaylorls@gmail.com>

Date: 2025-11-07T08:44:22Z

Lists: pgsql-hackers

Attachments

0001-Clean-up-qsort-comparison-function-for-GUC-entries.patch (text/plain) patch 0001
0002-Fix-backend-init-po-file-list.patch (text/plain) patch 0002
0003-Fix-NLS-for-incorrect-GUC-enum-value-hint-message.patch (text/plain) patch 0003

On 03.11.25 12:16, Peter Eisentraut wrote:
> The remaining patches to sort the list alphabetically have also been 
> pushed.

Here are a few more small patches to fix related things I found 
afterwards or in passing.

The first one straightens out how the qsort comparison function for GUC 
records works, and also removes the implicit requirement that the name 
field is first in the struct.

The second one fixes up an NLS build rule for the recent changes.

The third fixes some translation markers.  This is an older problem.

Commits

Remove extraneous newlines from guc_parameters.dat
- a7f59b252a8e 19 (unreleased) landed
Fix NLS for incorrect GUC enum value hint message
- 0fc33b00536c 19 (unreleased) landed
Clean up qsort comparison function for GUC entries
- d2f24df19b7a 19 (unreleased) landed
Sort guc_parameters.dat alphabetically by name
- fce7c73fba4e 19 (unreleased) landed
Reorganize GUC structs
- a13833c35f9e 19 (unreleased) landed
Change config_generic.vartype to be initialized at compile time
- e1a912c86d52 19 (unreleased) landed
Use designated initializers for guc_tables
- 0a7bde461016 19 (unreleased) landed
Change reset_extra into a config_generic common field
- 5f4c3b33a976 19 (unreleased) landed
Add some const qualifiers
- 29dc7a668753 19 (unreleased) landed
Modernize some for loops
- 1a795188889c 19 (unreleased) landed