Horton
Menu

Re: run pgindent on a regular basis / scripted manner

Andrew Dunstan <andrew@dunslane.net>

View thread
From: Andrew Dunstan <andrew@dunslane.net>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>, Jelte Fennema <postgres@jeltef.nl>, "shiy.fnst@fujitsu.com" <shiy.fnst@fujitsu.com>, Robert Haas <robertmhaas@gmail.com>, Justin Pryzby <pryzby@telsasoft.com>, Andres Freund <andres@anarazel.de>, Noah Misch <noah@leadboat.com>, Peter Geoghegan <pg@bowt.ie>, Bruce Momjian <bruce@momjian.us>, Magnus Hagander <magnus@hagander.net>, Alvaro Herrera <alvherre@2ndquadrant.com>, Stephen Frost <sfrost@snowman.net>, Jesse Zhang <sbjesse@gmail.com>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Date: 2023-05-18T12:59:28Z
Lists: pgsql-hackers 
On 2023-05-17 We 17:10, Tom Lane wrote:
> I wrote:
>> Andrew Dunstan<andrew@dunslane.net>  writes:
>>> I doubt there's something like that.
>> I had a read-through of the latest version's man page, and found
>> this promising-looking entry:
>> 	-boc, --break-at-old-comma-breakpoints
> Sadly, this seems completely not ready for prime time.  I experimented
> with it under perltidy 20230309, and found that it caused hundreds
> of kilobytes of gratuitous changes that don't seem to have a direct
> connection to the claimed purpose.  Most of these seemed to be from
> forcing a line break after a function call's open paren, like
>
> @@ -50,10 +50,12 @@ detects_heap_corruption(
>   #
>   fresh_test_table('test');
>   $node->safe_psql('postgres', q(VACUUM (FREEZE, DISABLE_PAGE_SKIPPING) test));
> -detects_no_corruption("verify_heapam('test')",
> +detects_no_corruption(
> +	"verify_heapam('test')",
>   	"all-frozen not corrupted table");
>   corrupt_first_page('test');
> -detects_heap_corruption("verify_heapam('test')",
> +detects_heap_corruption(
> +	"verify_heapam('test')",
>   	"all-frozen corrupted table");
>   detects_no_corruption(
>   	"verify_heapam('test', skip := 'all-frozen')",
>
> although in some places it just wanted to insert a space, like this:
>
> @@ -77,9 +81,9 @@ print "standby 2: $result\n";
>   is($result, qq(33|0|t), 'check streamed sequence content on standby 2');
>   
>   # Check that only READ-only queries can run on standbys
> -is($node_standby_1->psql('postgres', 'INSERT INTO tab_int VALUES (1)'),
> +is( $node_standby_1->psql('postgres', 'INSERT INTO tab_int VALUES (1)'),
>   	3, 'read-only queries on standby 1');
> -is($node_standby_2->psql('postgres', 'INSERT INTO tab_int VALUES (1)'),
> +is( $node_standby_2->psql('postgres', 'INSERT INTO tab_int VALUES (1)'),
>   	3, 'read-only queries on standby 2');
>   
>   # Tests for connection parameter target_session_attrs
>
>
> So I don't think we want that.  Maybe in some future version it'll
> be more under control.
>
> Barring objections, I'll use the attached on Friday.
>
> 			


LGTM


cheers


andrew

--
Andrew Dunstan
EDB:https://www.enterprisedb.com

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Fix comment from commit 22655aa231.

  2. Add a few recent commits to .git-blame-ignore-revs.

  3. Pre-beta2 mechanical code beautification.

  4. Pre-beta mechanical code beautification.

  5. Make agreed-on updates in perltidy options.

  6. Remove obsolete pgindent options --code-base and --build

  7. Integrate pg_bsd_indent into our build/test infrastructure.

  8. Sync pg_bsd_indent's copyright notices with Postgres practice.

  9. Import pg_bsd_indent sources.

  10. pgindent: filter files for the --commit option

  11. pgindent: more ways to find files to indent

  12. Fix pgindent --show-diff option.

  13. Add non-destructive modes to pgindent

  14. Initial pgindent run with pg_bsd_indent version 2.0.