Horton

Re: Combine Prune and Freeze records emitted by vacuum

Heikki Linnakangas <hlinnaka@iki.fi>

View thread View on postgr.es
From: Heikki Linnakangas <hlinnaka@iki.fi>
To: Melanie Plageman <melanieplageman@gmail.com>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>, Andres Freund <andres@anarazel.de>, Robert Haas <robertmhaas@gmail.com>, Peter Geoghegan <pg@bowt.ie>
Date: 2024-04-03T16:34:40Z
Lists: pgsql-hackers 
On 03/04/2024 17:18, Melanie Plageman wrote:
> I noticed you didn't make the comment updates I suggested in my
> version 13 here [1]. A few of them are outdated references to
> heap_page_prune() and one to a now deleted variable name
> (all_visible_except_removable).
> 
> I applied them to your v13 and attached the diff.

Applied those changes, and committed. Thank you!

>> Off-list, Melanie reported that there is a small regression with the
>> benchmark script she posted yesterday, after all, but I'm not able to
>> reproduce that.
> 
> Actually, I think it was noise.

Ok, phew.

-- 
Heikki Linnakangas
Neon (https://neon.tech)

Commits

  1. Combine freezing and pruning steps in VACUUM

  2. Refactor how heap_prune_chain() updates prunable_xid

  3. Introduce 'options' argument to heap_page_prune()

  4. Handle non-chain tuples outside of heap_prune_chain()

  5. Refactor heap_prune_chain()

  6. Minor refactoring in heap_page_prune

  7. Remove obsolete comment about VACUUM retrying pruning

  8. Merge prune, freeze and vacuum WAL record formats

  9. Remove unused PruneState member rel

  10. Reorganize heap_page_prune() function comment