Re: Add trailing commas to enum definitions
Andrew Dunstan <andrew@dunslane.net>
From: Andrew Dunstan <andrew@dunslane.net>
To: Tom Lane <tgl@sss.pgh.pa.us>, Nathan Bossart <nathandbossart@gmail.com>
Cc: Junwang Zhao <zhjwpku@gmail.com>, Peter Eisentraut
<peter@eisentraut.org>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2023-10-24T12:58:38Z
Lists: pgsql-hackers
On 2023-10-23 Mo 17:04, Tom Lane wrote: > Nathan Bossart <nathandbossart@gmail.com> writes: >> From a long-term perspective, I >> think standardizing on the trailing comma style will actually improve >> git-blame because patches won't need to add a comma to the previous line >> when adding a value. > Yeah, that's a good point. I had been leaning towards "this is > unnecessary churn", but with that idea I'm now +1. > > +1. It's a fairly common practice in Perl code, too, and I often do it for exactly this reason. cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com
Commits
-
Add "Add trailing commas to enum definitions" to .git-blame-ignore-revs
- 26f988212ead 17.0 landed
-
Add trailing commas to enum definitions
- 611806cd726f 17.0 landed