Horton

Re: psql :: support for \ev viewname and \sv viewname

Peter Eisentraut <peter.eisentraut@2ndquadrant.com>

View thread View on postgr.es
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Dean Rasheed <dean.a.rasheed@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Petr Korobeinikov <pkorobeinikov@gmail.com>, Jeevan Chalke <jeevan.chalke@enterprisedb.com>, Jeevan Chalke <jeevan.chalke@gmail.com>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2016-05-04T00:35:43Z
Lists: pgsql-hackers 

On 5/3/16 3:10 PM, Dean Rasheed wrote:
> On 3 May 2016 at 16:52, Peter Eisentraut
> <peter.eisentraut@2ndquadrant.com> wrote:
>> I would change appendReloptionsArrayAH() to a function and keep AH as the
>> first argument (similar to other functions that take such a handle).
>
> I can understand changing it to a function, but I don't think AH
> should be the first argument. All other append*() functions that
> append to a buffer have the buffer as the first argument, including
> the appendStringLiteralAH() macro on which this is based.

Well, all the functions that take archive handles have that as the first 
argument, so how do we consolidate that?

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Commits

  1. Fix psql's \ev and \sv commands so that they handle view reloptions.

  2. Move and rename fmtReloptionsArray().

  3. pgindent run for 9.5