Re: PATCH: Configurable file mode mask

David Steele <david@pgmasters.net>

From: David Steele <david@pgmasters.net>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Michael Paquier <michael@paquier.xyz>, Peter Eisentraut <peter.eisentraut@2ndquadrant.com>, Alvaro Herrera <alvherre@alvh.no-ip.org>, Stephen Frost <sfrost@snowman.net>, Adam Brightwell <adam.brightwell@crunchydata.com>, Robert Haas <robertmhaas@gmail.com>, "Tsunakawa, Takayuki" <tsunakawa.takay@jp.fujitsu.com>, Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2018-03-05T23:50:52Z
Lists: pgsql-hackers
On 3/5/18 5:51 PM, Tom Lane wrote:
> David Steele <david@pgmasters.net> writes:
>> On 3/5/18 5:11 PM, Tom Lane wrote:
>>> David Steele <david@pgmasters.net> writes:
>>>> I'm not sure what the protocol for introducing a new Perl module is?  I
>>>> couldn't find packages for the major OSes.  Are we OK with using CPAN?
> 
>>> I don't think that's cool.  Anything that's not part of a standard Perl
>>> installation is a bit of a lift already, and if it's not packaged by
>>> major distros then it's really a problem for many people.  (Yeah, they
>>> may know what CPAN is, but they might have local policy issues about
>>> installing directly from there.)
> 
>> It's a little different here, because these packages are only used for
>> testing/development.
> 
> True, but if we want this test to be part of either check-world or the
> buildfarm run, that's still a lot of people we're asking to install
> the extra module.  If we're talking about saving just a few dozen
> lines of code, it ain't worth it.

+1.

-- 
-David
david@pgmasters.net


Commits

  1. Allow group access on PGDATA

  2. Refactor dir/file permissions

  3. Revert "Add basic TAP test setup for pg_upgrade"

  4. Add basic TAP test setup for pg_upgrade